-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle failed transactions/blocks #2120
Merged
DaughterOfMars
merged 19 commits into
iotaledger:2.0
from
Thoralf-M:failed-transaction-handling
Mar 28, 2024
Merged
Handle failed transactions/blocks #2120
DaughterOfMars
merged 19 commits into
iotaledger:2.0
from
Thoralf-M:failed-transaction-handling
Mar 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thoralf-M
changed the title
Handle BlockState::Failed
Handle failed transactions/blocks
Mar 26, 2024
DaughterOfMars
previously approved these changes
Mar 27, 2024
Alex6323
previously approved these changes
Mar 28, 2024
thibault-martinez
approved these changes
Mar 28, 2024
DaughterOfMars
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Handle issues from posting the block, if we can't get it posted 3 times, we will return None for the block id and during syncing when we also can't get the block, we will set the tx state as conflicting and unlock its inputs so they're available for new transactions again.
Links to any relevant issues
#2111
Type of change
How the change has been tested
cli wallet and
with a modified operations/block.rs so we get the case where no block was sent